[enh] add array API enabled compute_class_weight function for use in classifier estimators
#2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
/intelci: run |
icfaust
requested review from
Alexsandruss,
ahuber21,
david-cortes-intel and
yuejiaointel
as code owners
Vika-F
reviewed
Sep 26, 2025
There was a problem hiding this comment.
The changes look good, I just have a couple of questions.
Also check_class_weight should be changed to compute_class_weight in the description.
And just for the sake of general understanding it would be good to know why this functionality is implemented as a hidden function in case of array API?
|
@Vika-F you are absolutely right. I will change the title. |
icfaust
changed the title
check_class_weight function for use in classifier estimatorscompute_class_weight function for use in classifier estimators
|
/intelci: run |
david-cortes-intel
approved these changes
Oct 1, 2025
|
/intelci: run |
Vika-F
approved these changes
Oct 1, 2025
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scikit-learn does not yet support any classifiers for array API. As such, there are core functions like
compute_class_weightwhich must be adapted locally for array API. This adds a private function_compute_class_weightfor use in sklearnex classifier estimators in order to enable them for array API. It uses an initial check usingget_namespaceand replicates line by line the functionality of sklearn written using the array API standard if necessary.This will be important for #2201 and #2209, as well as changes for KNeighborsClassifier.
Checklist:
Completeness and readability
Testing